0.34.6_repo_cleanup

src/balance/lease_runtime.rs

@@ -76,8 +76,6 @@ impl Lease {
             self.member.state.errors.fetch_add(1, Ordering::Relaxed);
         }
         self.member.state.record_failure(class, detail);
-        // GOAWAY(NO_ERROR) is a graceful H2 connection shutdown, not an
-        // origin failure. It can still be surfaced in access diagnostics.
         if matches!(class, "h2_graceful_goaway" | "h2_graceful_close") {
             return;
         }
@@ -368,8 +366,6 @@ async fn probe(member: Arc<Member>, settings: Arc<HealthCheck>) {
         tracing::info!(backend = %member.definition.id, healthy = after, reason = result, "backend health changed");
     }
 }
-/// One supervisor, at most 16 probes, at most one outstanding probe per member.
-/// DNS workers have their own shared bound and never resolve arbitrary URLs.
 pub async fn health_loop(app: Weak<crate::runtime::App>, shutdown: CancellationToken) {
     let mut interval = tokio::time::interval(Duration::from_millis(250));
     interval.set_missed_tick_behavior(tokio::time::MissedTickBehavior::Skip);
@@ -383,24 +379,14 @@ pub async fn health_loop(app: Weak<crate::runtime::App>, shutdown: CancellationT
             _ = interval.tick() => {
                 let Some(app) = app.upgrade() else { break; };
                 let snapshot = app.config.load_full();
-                // Own an Arc for each candidate. JoinSet tasks require an
-                // owned, 'static member rather than a reference into snapshot.
-                // Health settings were already compiled into each member.
-                // Reuse the immutable Arc instead of cloning each HealthCheck
-                // and recalculating per-member overrides on every 250ms tick.
                 let members: Vec<_> = snapshot.pools.iter().flat_map(|pool|
                     pool.members.iter().map(|member|
                         (Arc::clone(member), Arc::clone(&member.health_settings)))).collect();
                 for (member, _) in &members {
                     member.state.sample_traffic();
-                    // Time-based pool recycling must not depend on receiving a
-                    // request; otherwise idle backends can stay on generation 0
-                    // indefinitely after the configured recycle age elapses.
                     member.backend.client.maintain_rotation();
                     member.backend.websocket_client.maintain_rotation();
                 }
-                // Rotate the bounded probe window: slow first members must not
-                // starve later pools when all intervals equal their timeouts.
                 let start = cursor;
                 for offset in 0..members.len() {
                     if checks.len() >= 16 { break; }