0.34.6_repo_cleanup

src/proxy/forward/upstream.rs

@@ -7,8 +7,6 @@ if let Some(handshake) = &handshake {
     request.headers_mut().remove("content-length");
     request.headers_mut().remove("transfer-encoding");
     if websocket_upstream_h2 {
-        // Preserve CONNECT + :protocol=websocket for an explicit HTTP/2
-        // upstream. HTTP/1.1-only fields are forbidden on this hop.
         request.headers_mut().remove("connection");
         request.headers_mut().remove("upgrade");
         request.headers_mut().remove("sec-websocket-key");
@@ -21,8 +19,6 @@ if let Some(handshake) = &handshake {
             .headers_mut()
             .insert("upgrade", HeaderValue::from_static("websocket"));
         if !handshake.h1() {
-            // Extended CONNECT replaces the RFC 6455 proof headers on the
-            // downstream hop. Synthesize them only for an HTTP/1.1 backend.
             *request.method_mut() = Method::GET;
             request.headers_mut().remove("sec-websocket-key");
             request.headers_mut().remove("sec-websocket-accept");
@@ -40,11 +36,8 @@ if let Some(handshake) = &handshake {
     }
 }
 if let Some(auth) = frontend.and_then(|f| f.basic_auth.as_ref()) {
-    // Enforce after all custom request-header rules; they cannot restore credentials.
     auth.apply_upstream(request.headers_mut(), basic_identity);
 }
-// Transformation operates on the identity representation. Prefer identity from
-// the origin, while still decoding a supported encoding if the origin ignores it.
 if range_requested || transform_settings.is_some_and(|settings| settings.enabled) {
     request.headers_mut().remove("accept-encoding");
 }
@@ -54,16 +47,9 @@ if pending_revalidation {
         revalidation_sent = cached.apply_validators(request.headers_mut());
     }
 }
-// Varnish hashes HEAD with GET and turns a regular cacheable backend fetch
-// into GET. The outer response middleware still strips the body for the
-// original HEAD client, while a MISS can populate the shared GET object.
 if request.method() == Method::HEAD && cache_ticket.is_some() {
     *request.method_mut() = Method::GET;
 }
-// Save the pre-normalization headers only for replayable requests that may
-// actually be retried. The common one-backend HTTP/1 route has no retry peer
-// or H2 GOAWAY handling, so copying HeaderMap for every request was wasted.
-// Never replay writes, streaming uploads, auth or WebSocket requests.
 let retry_method = request.method().clone();
 let retry_policy = route.pool.as_ref().map(|pool| &pool.settings.retry);
 let pool_retry_possible = route.backend_id.is_none()
@@ -137,8 +123,6 @@ if websocket_upstream_h2 {
     *request.body_mut() = websocket::wrap_h2_request_body(body, session.clone(), exchange);
     h2_direct_session = Some(session);
 }
-// Do not classify a slow client upload as a slow origin response. Probes
-// independently measure origin liveness/latency with body-free requests.
 let request_body_empty = request.body().size_hint().exact() == Some(0);
 let proactive_base_headers = if cache_ticket.is_some() && cache_settings.proactive_refresh_enabled {
     request.headers().clone()