v0.34.0_2

src/proxy/headers/tests.rs

@@ -19,6 +19,29 @@ mod tests {
         h.insert("connection", "keep-alive, Upgrade".parse().unwrap());
         assert!(requests_upgrade(&h));
     }
+    #[test]
+    fn absent_cookies_leave_headers_unchanged() {
+        let mut headers = HeaderMap::new();
+        headers.insert("x-pass", "yes".parse().unwrap());
+        assert!(strip_admin_cookie(&mut headers).is_empty());
+        strip_admin_set_cookie(&mut headers);
+        assert_eq!(headers.get("x-pass").unwrap(), "yes");
+        assert!(!headers.contains_key(http::header::COOKIE));
+        assert!(!headers.contains_key(http::header::SET_COOKIE));
+    }
+
+    #[test]
+    fn set_cookie_keeps_valid_unreserved_values() {
+        let mut headers = HeaderMap::new();
+        headers.append("set-cookie", "a=1; Secure".parse().unwrap());
+        headers.append("set-cookie", "rustproxy_session=secret".parse().unwrap());
+        headers.append("set-cookie", "b=2; HttpOnly".parse().unwrap());
+        strip_admin_set_cookie(&mut headers);
+        let cookies: Vec<_> = headers.get_all("set-cookie").iter()
+            .map(|value| value.to_str().unwrap()).collect();
+        assert_eq!(cookies, vec!["a=1; Secure", "b=2; HttpOnly"]);
+    }
+
     #[test]
     fn admin_cookie_can_be_restored_only_from_captured_fragment() {
         let mut h = HeaderMap::new();