v0.34.0_7

src/balance/lease_runtime.rs

@@ -40,24 +40,21 @@ impl Lease {
             "ok"
         };
         let before = self.member.state.healthy();
-        let failure_detail = if is_5xx {
-            format!("status={status}")
-        } else {
-            reason.into()
-        };
+        let failure_detail = is_5xx.then(|| format!("status={status}"));
+        let detail = failure_detail.as_deref().unwrap_or(reason);
         let ejected = self.member.state.observe_passive_with_detail(
             &self.health,
             &self.passive_health,
             reason,
             reason,
-            &failure_detail,
+            detail,
             elapsed,
         );
         if let Some((first, failures)) = ejected {
             tracing::warn!(backend = %self.member.definition.id, origin = %self.member.backend.origin, source = "passive",
                 reason, first_error_class = first.class,
                 first_error_at_ms = first.at_ms, first_error_detail = %first.detail,
-                trigger_error_detail = %failure_detail, failures,
+                trigger_error_detail = %detail, failures,
                 "backend excluded from traffic");
         }
         let after = self.member.state.healthy();