fix profile-scoped backups and shared profile rules

pytorrent/services/operation_logs.py

@@ -104,12 +104,13 @@ def get_settings(profile_id: int = 0, user_id: int | None = None) -> dict:
     profile_id = int(profile_id or 0)
     with connect() as conn:
         row = conn.execute(
-            "SELECT * FROM operation_log_settings WHERE user_id=? AND profile_id=?",
-            (user_id, profile_id),
+            "SELECT * FROM operation_log_settings WHERE profile_id=? ORDER BY updated_at DESC, user_id ASC LIMIT 1",
+            (profile_id,),
         ).fetchone()
     if not row:
-        return {"user_id": user_id, "profile_id": profile_id, **DEFAULT_SETTINGS}
+        return {"owner_user_id": user_id, "profile_id": profile_id, **DEFAULT_SETTINGS}
     data = {**DEFAULT_SETTINGS, **dict(row)}
+    data["owner_user_id"] = int(data.pop("user_id", user_id) or user_id)
     data["retention_mode"] = data.get("retention_mode") if data.get("retention_mode") in VALID_RETENTION_MODES else "days"
     data["retention_days"] = max(1, int(data.get("retention_days") or DEFAULT_SETTINGS["retention_days"]))
     data["retention_lines"] = max(100, int(data.get("retention_lines") or DEFAULT_SETTINGS["retention_lines"]))
@@ -125,16 +126,14 @@ def save_settings(profile_id: int, data: dict, user_id: int | None = None) -> di
     days = max(1, min(3650, int(data.get("retention_days") or DEFAULT_SETTINGS["retention_days"])))
     lines = max(100, min(1_000_000, int(data.get("retention_lines") or DEFAULT_SETTINGS["retention_lines"])))
     now = utcnow()
+    if not auth.can_write_profile(profile_id, user_id):
+        raise PermissionError("No write access to profile")
     with connect() as conn:
+        conn.execute("DELETE FROM operation_log_settings WHERE profile_id=?", (profile_id,))
         conn.execute(
             """
             INSERT INTO operation_log_settings(user_id, profile_id, retention_mode, retention_days, retention_lines, created_at, updated_at)
             VALUES(?,?,?,?,?,?,?)
-            ON CONFLICT(user_id, profile_id) DO UPDATE SET
-              retention_mode=excluded.retention_mode,
-              retention_days=excluded.retention_days,
-              retention_lines=excluded.retention_lines,
-              updated_at=excluded.updated_at
             """,
             (user_id, profile_id, mode, days, lines, now, now),
         )